Add Arc::flipped
#367
Merged
Add Arc::flipped
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
reviewed
Aug 20, 2024
richard-uk1
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
LGTM.
@DJMcNab these kinds of operations can be useful sometimes, for applications other than drawing (when it really doesn't matter what direction the line goes in).
| assert_eq!(a.sweep_angle, -f.sweep_angle); | ||
|
|
||
| // Flipping it again should result in the original arc | ||
| assert_eq!(a, f.flipped()); |
There was a problem hiding this comment.
No fuzzy testing needed, since there is only addition/subtraction meaning perfect accuracy, at least for normal input.
There was a problem hiding this comment.
You are confirming what I have here is fine, not suggesting a change, right?
waywardmonkeys
force-pushed
the
arc-flipped
branch
from
c525dad
to
26bf67a
Compare
waywardmonkeys
force-pushed
the
arc-flipped
branch
from
26bf67a
to
2ea831a
Compare
|
What are the next steps here? |
|
I am going to land it before the meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.